Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
Fix rpm
Changes
Files changed
File: sdk/node/scripts/build-binaries.sh
What: Outputs to bin/${OS}-${ARCH}/ (subdir) instead of flat bin/; .pilot-version stays
────────────────────────────────────────
File: sdk/node/src/runtime.ts
What: New pkgBinRoot() (top-level bin/) + pkgBinDir() (platform subdir);
bundledVersion() reads from root; platformDirName() helper
────────────────────────────────────────
File: sdk/node/src/ffi.ts
What: findLibrary() fallback for npm package layout now looks in bin/-/
────────────────────────────────────────
File: sdk/node/tests/runtime.test.ts
What: Test fixture builds proper layout (root + platform subdir + version marker); +1
new test for missing-platform-subdir case
────────────────────────────────────────
File: .github/workflows/publish-node-sdk.yml
What: Adds workflow_dispatch (inputs: version, prerelease); each matrix runner uploads
its bin/ subdir as node-bin-{linux,macos}; publish job downloads both, merges macOS
subdirs into Linux package base, then publishes one multi-platform npm package
────────────────────────────────────────
File: .github/workflows/publish-python-sdk.yml
What: Adds workflow_dispatch (same inputs); gating moved from test-sdk to publish so
dispatch can do "build only" for prereleases
Verification done
symlink failure)
sdk/node/bin/darwin-arm64/{pilot-daemon, pilotctl, pilot-gateway, pilot-updater,
libpilot.dylib} + sdk/node/bin/.pilot-version
-e)